NOISSUE - Add custom Wasm component export invocation support#170
Merged
rodneyosodo merged 21 commits intoabsmach:mainfrom Mar 30, 2026
Merged
NOISSUE - Add custom Wasm component export invocation support#170rodneyosodo merged 21 commits intoabsmach:mainfrom
rodneyosodo merged 21 commits intoabsmach:mainfrom
Conversation
dcaf443 to
8b8155f
Compare
3162623 to
92fbd93
Compare
… tests The new function_name field on StartRequest was missing from 10 test struct literals, causing cargo test --release to fail with E0063. Added function_name: None to all affected test fixtures. Also added three targeted tests for the new field: - test_start_request_function_name_present: deserialize with field set - test_start_request_function_name_absent_defaults_to_none: backward compat — old payloads without the field still deserialize cleanly - test_start_request_function_name_roundtrip: ser/deser with WAVE-encoded inputs (Vec<String>) and custom function_name round-trips correctly
Extend is_wasm_component to accept 0x0d (wasm-tools >= 0.200 / wit-component 0.241.2) in addition to 0x0a (older wasm-tools). Without this, components built with modern tooling were misidentified as core modules, causing the --invoke flag to be called without WAVE-encoded arguments and producing a parse error at runtime. Adds four regression tests covering old format, new format, core module rejection, and too-short binary rejection.
92fbd93 to
38862bd
Compare
…ntifier name already served as the function name (validated with 'name is required'). function_name was redundant — the only purpose was as an optional override that fell back to name anyway. Simplify by using name directly throughout.
rodneyosodo
requested changes
Mar 26, 2026
rodneyosodo
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this do?
Adds custom Wasm component export invocation support
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
No new tests; existing tests updated for new field
Did you document any new/modified features?
Yes
Notes